Add support for DenormalizerInterface::denormalize #54
Conversation
|
Hi, if the code is the same it shouldn't be done with copy-pasting source code but with reusing the same class as a different DI service. |
tyx
force-pushed
the
feature/denormalizer-interface
branch
from
028dbc8 to
d96eaa0
Compare
|
Yes only But I'm not sure to know what you mean behind
You want to inject through the constructor the variable stuff ? or by inheritance and override concerned methods ? |
tyx
force-pushed
the
feature/denormalizer-interface
branch
from
d96eaa0 to
4a4f888
Compare
|
Injecting in constructor. Register it in extension.neon multiple times with different arguments. |
tyx
force-pushed
the
feature/denormalizer-interface
branch
2 times, most recently
from
98c6d26 to
d369fe8
Compare
tyx
force-pushed
the
feature/denormalizer-interface
branch
from
d369fe8 to
4073030
Compare
|
Ok, here it is ! But I'm not sure to know why tests with |
|
That’s an unrelated error from newer version of PHPStan.
On Mon, 8 Jul 2019 at 16:31, Timothée Barray ***@***.***> wrote:
Ok, here it is !
But I'm not sure to know why tests with highest dependencies fail. If
anyone can help on this, please let me know.
PHPStan\Type\Symfony\EnvelopeReturnTypeExtensionTest::testAll with data set #0 ('$test1', 'array<Symfony\Component\Messe...Stamp>')
ArgumentCountError: Too few arguments to function PHPStan\Analyser\NodeScopeResolver::__construct(), 9 passed in /home/travis/build/phpstan/phpstan-symfony/tests/Type/Symfony/ExtensionTestCase.php on line 55 and exactly 10 expected
/home/travis/build/phpstan/phpstan-symfony/vendor/phpstan/phpstan/src/Analyser/NodeScopeResolver.php:140
/home/travis/build/phpstan/phpstan-symfony/tests/Type/Symfony/ExtensionTestCase.php:55
/home/travis/build/phpstan/phpstan-symfony/tests/Type/Symfony/EnvelopeReturnTypeExtensionTest.php:21
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#54?email_source=notifications&email_token=AAAZTOHFPSFWLK5QETWZNRLP6NFV3A5CNFSM4H63BJY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNITLY#issuecomment-509249967>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAZTOGVDWE24ZMYG4FIQNTP6NFV3ANCNFSM4H63BJYQ>
.
--
Ondřej Mirtes
|
|
Indeed here is the commit that breaks test highest deps : I updated to change ExtensionTestCase by adding true to the NodeScopeResolver constructor. edit: unfortunately this change breaks the Please let me know what is the best solution for you. |
|
I'll take a look tonight. We might have to do some fancy schmancy magic to accomodate for both old and new PHPStan versions.. |
|
You should open 0.12-dev before merging this, that will make your job easier. |
|
Any hope this will be merged soon? |
|
We still need to find a way to make both world (lowest and highest deps) green. I should admit I am using my fork for now as I failed to make it green ^^ |
|
Guys, sorry, I completely forgot about this. I will fix and merge it this weekend during a hackathon. Thank you for your patience. |
|
Thanks! |
|
Great! Thanks for your help! |
|
I guess we are close to publish a new release ? |
5 participants
Hi people,
As SerializerInterface, DenormalizerInterface has the same trouble.
So I just copy the code and adapt it to work with DenormalizerInterface.